mullvad / mullvadvpn-app

The Mullvad VPN client app for desktop and mobile
https://mullvad.net/
GNU General Public License v3.0
5.13k stars 342 forks source link

Auto-Hiding in unpinned mode #5114

Open Recliness opened 1 year ago

Recliness commented 1 year ago

Feature Request

Operating system: Windows 11

App version: 2023.4

Description

Make it so that you can auto-hide the app when it is unpinned from the taskbar. This would make it so I could move the app to an ideal location but not have to always minimize it or click the X to get it out of my way.

faern commented 1 year ago

What do you mean with auto-hide? That it hides as soon as it loses focus, like in the pinned-to-taskbar mode? I think that would be very unexpected behavior of a window on Windows. Do you have an example of other apps that do this, or why should we behave different?

You can just alt-f4 if that's faster maybe? We are quite restrictive with adding settings toggles for too niche things. It complicates the UI for everyone and maybe only helps a few.

Recliness commented 1 year ago

Well, then it would be nice to be able to reposition the “pinned to taskbar” mode. The problem with it is that it pops up in the center of my screen. This could just be a simple toggle that’s off by default 🤷‍♂️

faern commented 1 year ago

To me it sounds like what you want is for the Window to remember its position and re-open there when you re-open it in unpinned mode?

faern commented 1 year ago

Sorry, I think I misread what you wrote. Our app already remembers the last used window position when you re-open it in unpinned mode. And no, we won't make it possible to reposition the pinned window. The entire point of the pinned-to-taskbar window is that it should act as a sort of context menu to the task bar icon.

If your window shows up in the center of the screen when pinned to the task bar, that's because our code can't find the position of the tray icon. And that in turn is probably because your Mullvad tray icon is hidden. If you draw it out of the "drawer" of collected icons and make it always visible in the tray bar, then the pinned mode will always open next to the icon (in the corner)

Recliness commented 1 year ago

Ah, would it possible for that to work when the task-bar automatically hides? I am using a small laptop screen so the taskbar tends to take up an important part of it. If this was possible it would fix my issue

I have already drawn the app out of the hidden icons and onto the taskbar :)

faern commented 1 year ago

We will look into having the window default to the lower right corner instead of screen center when the tray icon position can't be obtained :+1:

Recliness commented 1 year ago

That would be so cool! Thanks!

Recliness commented 1 year ago

I hate to say this, but I would suggest making that an option because some people may not like the change :)

Recliness commented 1 year ago

We will look into having the window default to the lower right corner instead of screen center when the tray icon position can't be obtained 👍

is there a time estimate on this? I know you guys have bigger bugs to fix so its no rush :)

raksooo commented 1 year ago

We haven't been able to prioritize this yet unfortunately, so we don't have an ETA.