search

mullvad / windows-service-rs

Windows services in Rust
Apache License 2.0
521 stars 85 forks source link

Add missing standard access rights for `ServiceAccess` #129

Closed Legend-Master closed 6 months ago

Legend-Master commented 6 months ago

I don't know if we should provide all combination flags like GENERIC_READ listed in https://learn.microsoft.com/en-us/windows/win32/services/service-security-and-access-rights#access-rights-for-a-service, but at least we need to have READ_CONTROL, WRITE_DAC, WRITE_OWNER for modifying security descriptors, this is often used in updater services for preventing UAC prompts

This change is Reviewable

faern commented 6 months ago

This seems sane to me! But I'll let @dlon have a say also.

faern commented 6 months ago

Thank you for the contribution!

Legend-Master commented 6 months ago

Just a note, this PR includes the changes made in #121, so maybe we can close it as completed now

faern commented 6 months ago

Oh. I didn't notice they overlap. I sort of forgot about the other PR. Thanks.