search

multi-build / docker-images

BSD 2-Clause "Simplified" License
1 stars 8 forks source link

Add Dockerfile to build Python 3.8, 3.9, and 3.10 on Alpine Linux #20

Closed stefanv closed 2 years ago

stefanv commented 2 years ago

Dockerfile to build container required for https://github.com/matthew-brett/multibuild/pull/430

mattip commented 2 years ago

Is using a single RUN command instead of breaking each command into a separate RUN the recommended way to structure a Dockerfile? I would think separate commands give a more layered approach to running the docker build.

stefanv commented 2 years ago

Is using a single RUN command instead of breaking each command into a separate RUN the recommended way to structure a Dockerfile? I would think separate commands give a more layered approach to running the docker build.

Yes, this is purposeful. It turns out that adding layers is very costly in terms of image size, and the best way to keep them small is to combine commands.

matthew-brett commented 2 years ago

Nice - thanks for doing this ...

matthew-brett commented 2 years ago

Test failure looks unrelated? Does this need a Travis-CI entry?

stefanv commented 2 years ago

I added a matrix entry for Alpine.

mattip commented 2 years ago

Cool, thanks. Is there a way to confirm that the container is usable in https://github.com/multi-build/multibuild/pull/430 (note that the repo has moved)

matthew-brett commented 2 years ago

I guess the trick would be to put the image up somewhere, so we could use it to test against the PR ...

mattip commented 2 years ago

Probably the easiest way to do that is to merge this, so in it goes.

mattip commented 2 years ago

The docker image is up https://hub.docker.com/u/multibuild. It is called "focal_alpine", maybe it should be alpine_x86_64 like the focal_x86_64 one. Is there a chance we will see an alpine_arm64v8 or alpine_i686 ?