multi-build / docker-images

BSD 2-Clause "Simplified" License
1 stars 9 forks source link

rename focal_alpine image to alpine_x86_64 #21

Closed mattip closed 3 years ago

mattip commented 3 years ago

The deploy.sh script takes only one argument for the $PLATFORM so in PR #20 that took on the name alpine resulting in a focal_alpine docker tag. It would be nice to refactor this to use a $DISTRO, with a default of focal. https://github.com/multi-build/docker-images/blob/5a2fae9f6ee3a60f39ca62e08c1a408fa33e01d2/deploy.sh#L1-L8

mattip commented 3 years ago

@stefanv ?

stefanv commented 3 years ago

The distinction between Alpine and Ubuntu seems less the distribution than the libc being used. If you think $DISTRO is the right way to go, I'm happy to make that modification; otherwise $LIBC?

stefanv commented 3 years ago

I'll do the $DISTRO thing for now, and we can refactor later.