search

multi-build / docker-images

BSD 2-Clause "Simplified" License
1 stars 9 forks source link

Add DIST flag to disambiguate Alpine 3.14 from Ubuntu Focal #22

Closed stefanv closed 3 years ago

stefanv commented 3 years ago

I don't have an easy way to check this, so I'll let your eyes be my safeguard.

Closes #21

mattip commented 3 years ago

LGTM, thanks

mattip commented 3 years ago

I was too quick to commit. Somehow the $DIST env variable is not getting thorugh to the scripts. The images that were uploaded to https://hub.docker.com/u/multibuild have an empty $DIST descriptor, they are also missing the _ character that I would have expected for $DIST_$PLATFORM if $DIST were empty

stefanv commented 3 years ago

@mattip Do you know how $PLATFORM makes it through to deploy.sh?

mattip commented 3 years ago

Maybe the '' is tripping up the shell, can you try `${DIST}${PLATFORM}` ? For instance, this works with the braces but is broken without

$ ABC=hello.14 DEF=world echo x${ABC}_${DEF}y
xhello.14_worldy
stefanv commented 3 years ago

I bet that's it.