search

multi-build / docker-images

BSD 2-Clause "Simplified" License
1 stars 9 forks source link

Use curly brackets for referring to shell variables #24

Closed stefanv closed 3 years ago

mattip commented 3 years ago

At least now we get an error

invalid argument "multibuild/Alpine3.14_x86_64:2100f7beb37bcb299f1cfa4956887287b12fd93f" \
    for "-t, --tag" flag: invalid reference format: repository name must be lowercase
mattip commented 3 years ago

Perhaps using alpine3_14 would be accepted instead?

mattip commented 3 years ago

LGTM, the last lint of the log is successfully tagged multibuild/alpine3.14_x86_64:6b8ccb641a67421aada80fa6190adbcb5b5b73f3

mattip commented 3 years ago

Thanks @stefanv

stefanv commented 3 years ago

@mattip We may want to use a dash instead of underscore so the distro and arch can be split out again?

mattip commented 3 years ago

I am not sure I see the use case. These images are only for consumption by multibuild at this point. If new needs arise, we can rethink this.