search

multi-build / docker-images

BSD 2-Clause "Simplified" License
1 stars 8 forks source link

Updated install_pypy #5

Closed radarhere closed 3 years ago

radarhere commented 3 years ago

Updated install_pypy to latest multibuild version

mattip commented 3 years ago

There is a distinct lack of tests here :(. Did you check that running the docker image works (docker run -it ... gives a functioning python environment) on both x86_64 and macOS?

radarhere commented 3 years ago

I haven't tested it that extensively, no. I just presumed that the same arguments for updating the code in multibuild also applied to updating the code here.

mattip commented 3 years ago

makes sense. They have some tests, I guess we should set up some minimal testing here.

radarhere commented 3 years ago

I've realised that in this PR's current form, it requires 'untar' and 'fill_pypy_ver', which don't exist here.

I'm going to start out simpler instead, with #6

radarhere commented 3 years ago

This was then continued in #9