search

multi-build / multibuild

Machinery for building and testing Python Wheels for Linux, OSX and (less flexibly) Windows.
Other
240 stars 88 forks source link

get_modern_cmake - version 3? #439

Open snowman2 opened 2 years ago

snowman2 commented 2 years ago

Currently it attempts to get 28, but the default cmake version is 3.21.3.

https://github.com/multi-build/multibuild/blob/b35c219f90b9cfb8a2ba878cc0816979f8214f56/library_builders.sh#L193-L195

$ docker run --rm -it --entrypoint bash --network host quay.io/pypa/manylinux2010_i686:latest
# yum search cmake | grep ^cmake
cmake-fedora.noarch : CMake helper modules for fedora developers
cmake-gui.i686 : Qt GUI for cmake
cmake28-gui.i686 : Qt GUI for cmake28
cmake3-data.noarch : Common data-files for cmake3
cmake3-doc.noarch : Documentation for cmake3
cmake3-gui.i686 : Qt GUI for cmake3
cmake.i686 : Cross-platform make system
cmake28.i686 : Cross-platform make system
cmake3.i686 : Cross-platform make system
# cmake --version
cmake version 3.21.3

Is there a reason not to use version 3?

mattip commented 1 week ago

I think that stanza is really outdated. We can just remove it. The function also does not check if cmake is currently installed already, as it is in most current CI images.