Closed radarhere closed 1 year ago
When searching for wheels to fuse, multibuild currently uses MB_PYTHON_OSX_VER to search for the wheels that were built.
MB_PYTHON_OSX_VER
https://github.com/multi-build/multibuild/blob/c0a319a5358538b1bf561908f740b24999c76370/osx_utils.sh#L508-L516
I think this should be MACOSX_DEPLOYMENT_TARGET instead.
MACOSX_DEPLOYMENT_TARGET
To demonstrate, I've created a simplified branch of pillow-wheels - https://github.com/radarhere/pillow-wheels/tree/demo. All it does to set the macOS version for the wheels is export MACOSX_DEPLOYMENT_TARGET="10.10"
export MACOSX_DEPLOYMENT_TARGET="10.10"
Without this change, there is no universal2 wheel at the end of a build. With this change, there is.
When searching for wheels to fuse, multibuild currently uses
MB_PYTHON_OSX_VERto search for the wheels that were built.https://github.com/multi-build/multibuild/blob/c0a319a5358538b1bf561908f740b24999c76370/osx_utils.sh#L508-L516
I think this should be
MACOSX_DEPLOYMENT_TARGETinstead.To demonstrate, I've created a simplified branch of pillow-wheels - https://github.com/radarhere/pillow-wheels/tree/demo. All it does to set the macOS version for the wheels is
export MACOSX_DEPLOYMENT_TARGET="10.10"Without this change, there is no universal2 wheel at the end of a build. With this change, there is.