search

multi-tenant / grails-multi-tenant-single-db

Multi Tenant implementation for single database environments - Use grails-filtering and grails-hibernate-hijacker
Apache License 2.0
32 stars 25 forks source link

Unable to delete when using withoutTenantRestriction #11

Closed sronderos closed 12 years ago

sronderos commented 12 years ago

I happened upon this issue during my development. Currently the hibernate filter prevents deletes from executing when the current tenant id is null. It is my understanding that having no current tenant id should allow unrestricted access to view, update or delete assets.

Please let me know if the delete functionality was not intended to work with the "withoutTenantRestriction" feature.

kimble commented 12 years ago

That sounds about right, but it's a bit hard to see what has changed in the patch..

sronderos commented 12 years ago

Oh, I didn't notice how awful the merge was. I expect it has something to do with line endings. I'll see if I can clean it up to make the patch easier to read.

sronderos commented 12 years ago

Ok, those files should be easier to read now. Somehow I also had some bad line endings in documentation that I had written the other day, and apparently the license had CRLF in it as well. Sorry for the clutter in the diff view, but it should be easier to see the changes I made for the delete functionality.

kimble commented 12 years ago

Looks good to me, I've never really used the "no tenant back door" which is probably why I've never experienced any issues with it.