search

multiSnow / mcomix3

End of Fork
Other
96 stars 39 forks source link

Add delete action #120

Closed bonnefoa closed 3 years ago

bonnefoa commented 4 years ago

Add delete action to remove currently opened file or archive. Most of the code is copied from https://github.com/mxtthias/mcomix/blob/master/mcomix/main.py#L1023-L1067 with minor modifications.

multiSnow commented 4 years ago

Sorry, this PR, and any PR about delete operation will not be merged.

The delete operation would be confused. What it would delete? Page? Which page in dual page mode? Which page in manga mode? Book? The whole directory? What about non-image file? How to delete? directly unlink? the 'trash' provided by DE? Program could not read user's mind, and it shoud never do it.

mcomix already provided external command interface. Any operation out of mcomix should use it.

mcomix should be a viewer, but already did far more than that. No more, please.

Also see https://github.com/multiSnow/mcomix3/issues/115#issuecomment-623037323.