multiarch / centos

:earth_africa: `centos` Docker image for multiple architectures
MIT License
9 stars 5 forks source link

Add new version CentOS 7.6 dropping old versions #10

Closed junaruga closed 5 years ago

junaruga commented 5 years ago

It's same with another PR (https://github.com/multiarch/centos/pull/9) that was wrongly merged and canceled.

But I decided to share this PR, because I need your advises.

The situation is ...

As current exist 7.2.1511-${arch} 's image URLs do not exist except x86_64, those do not work. I updated to latest CentOS 7.6 (or 7.5) image files. Then, x86_64 and armhfp work. But other archs do not work. (docker build -t $repo:$version-iso iso works, but docker run -it --rm $repo:$version-iso ... does not work.)

Here is my repository's result. https://travis-ci.org/junaruga/centos/builds/531571388

Could you give me some advises?

Thank you.


Other notable features

junaruga commented 5 years ago

@moul @moul-sudo I appreciate if you give me some advices for this PR when you have a time.

Detail: https://travis-ci.org/multiarch/centos/builds/531722254

junaruga commented 5 years ago

I rebased to pass the CI. I tried some ways to solve the invalid container images' issue. But as I could not solve it, I commented out those cases. I think this PR is still better than current master branch and CI's situation. Shall we merge this?

As a note, I removed Dockerfile files on the repository. As those are generated in update.sh, I think we do not have to keep those on the repository.

junaruga commented 5 years ago

@lafin could you review this PR?

junaruga commented 5 years ago

@lafin thanks for your review. I merged it now.