PHPDoc wrong return type for Friendable::findFriendships

multicaret / laravel-acquaintances

This package gives Eloquent models the ability to manage friendships (with groups), followships along with Likes, favorites..etc.

https://laravel-news.com/manage-friendships-likes-and-more-with-the-acquaintances-laravel-package

MIT License

814 stars 72 forks source link

PHPDoc wrong return type for Friendable::findFriendships #96

Open FlYos opened 1 year ago

FlYos commented 1 year ago

Hi,

If I am not mistaken, I believe the PHPDoc is wrong for the return type. It should be Illuminate\Database\Eloquent\Builder instead of Illuminate\Database\Eloquent\Collection, It's right ?

https://github.com/multicaret/laravel-acquaintances/blob/74038bc4b9cca6d4d6e6176cecff6e16fc4a5faf/src/Traits/Friendable.php#L428-L467

mkwsra commented 1 year ago

Yes indeed, please give it a run on your locale machine after you change the libraries file from within /vendor and if everything is okay, can you please create a PR? I would be glad to accept it.

Thanks for noticing this