search

multicloud-ops / build-harness-extensions

1 stars 8 forks source link

GITHUB_TOKEN not needed for every make invocation #7

Closed cbarlock closed 4 years ago

cbarlock commented 4 years ago

The GITHUB_TOKEN is only needed to download .BuildHarnessConfig.global from github. This change tests if the file exists and, if so, does not check for GITHUB_TOKEN and does not download the file again, which should speed up the build.

hassenius commented 4 years ago

The changes in the PR and the description of the PR doesn't quite match? I agree that we can probably remove the need for always having a GITHUB_TOKEN set, even when we don't need it for the specific target. But the commits seems to modify things with the go-ext module and the docker module to add support for fat manifests?

cbarlock commented 4 years ago

My mistake. I'll close this and open another PR.

cbarlock commented 4 years ago

Too many repos! I should have pushed the change to cicd-example-repo.