gyliu513
commented
4 days ago watsonx
(pr-agent) gyliu@guangyas-air pr-agent % /Users/gyliu/pr-agent/bin/python /Users/gyliu/go/src/github.com/Codium-ai/pr-agent/pr_agent/cli_pip.py 2024-07-03 22:11:18.792 | INFO | pr_agent.git_providers.git_provider:get_main_pr_language:220 - No languages detected 2024-07-03 22:11:18.794 | INFO | pr_agent.tools.pr_code_suggestions:init:35 - Setting max_model_tokens to 10000 for PR improve 2024-07-03 22:11:18.795 | INFO | pr_agent.tools.pr_code_suggestions:_get_is_extended:352 - Extended mode is enabled automatically based on the configuration toggle 2024-07-03 22:11:18.970 | INFO | pr_agent.tools.pr_code_suggestions:run:74 - Generating code suggestions for PR... 2024-07-03 22:11:18.971 | DEBUG | pr_agent.tools.pr_code_suggestions:run:77 - Relevant configs 2024-07-03 22:11:19.364 | DEBUG | pr_agent.algo.pr_processing:retry_with_fallback_models:329 - Generating prediction with watsonx/meta-llama/llama-3-8b-instruct 2024-07-03 22:11:19.669 | INFO | pr_agent.tools.pr_code_suggestions:_prepare_prediction_extended:360 - Number of PR chunk calls: 1 2024-07-03 22:11:19.669 | DEBUG | pr_agent.tools.pr_code_suggestions:_prepare_prediction_extended:361 - PR diff: 2024-07-03 22:11:19.669 | INFO | pr_agent.tools.pr_code_suggestions:_prepare_prediction_extended:362 - ['\n\n## file: \'pr-agent.py\'\n\n@@ -0,0 +1,9 @@\nnew hunk\n1 +# This program prints Hello, world!\n2 +\n3 +printfx(\'Hello, world!\')\n4 +\n5 +for i=0; i<10; i++ {\n6 + printfx("how to build for loop")\n7 +}\n8 +\n9 +# There aare soome typooo'] 2024-07-03 22:11:19.674 | DEBUG | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:155 - Prompts 2024-07-03 22:11:19.674 | INFO | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:158 - System prompt: You are PR-Reviewer, a language model that specializes in suggesting ways to improve for a Pull Request (PR) code. Your task is to provide meaningful and actionable code suggestions, to improve the new code presented in a PR diff.
The format we will use to present the PR code diff:
file: 'src/file1.py'
@@ ... @@ def func1(): new hunk 12 code line1 that remained unchanged in the PR 13 +new hunk code line2 added in the PR 14 code line3 that remained unchanged in the PR old hunk code line1 that remained unchanged in the PR -old hunk code line2 that was removed in the PR code line3 that remained unchanged in the PR
@@ ... @@ def func2(): new hunk ... old hunk ...
file: 'src/file2.py'
...
- In this format, we separated each hunk of code to 'new hunk' and 'old hunk' sections. The 'new hunk' section contains the new code of the chunk, and the 'old hunk' section contains the old code that was removed.
- Code lines are prefixed symbols ('+', '-', ' '). The '+' symbol indicates new code added in the PR, the '-' symbol indicates code removed in the PR, and the ' ' symbol indicates unchanged code.
- We also added line numbers for the 'new hunk' sections, to help you refer to the code lines in your suggestions. These line numbers are not part of the actual code, and are only used for reference.
Specific instructions for generating code suggestions:
- Provide up to 4 code suggestions. The suggestions should be diverse and insightful.
- The suggestions should focus on ways to improve the new code in the PR, meaning focusing on lines from 'new hunk' sections, starting with '+'. Use the 'old hunk' sections to understand the context of the code changes.
- Prioritize suggestions that address possible issues, major problems, and bugs in the PR code.
- Don't suggest to add docstring, type hints, or comments, or to remove unused imports.
- Suggestions should not repeat code already present in the 'new hunk' sections.
- Provide the exact line numbers range (inclusive) for each suggestion. Use the line numbers from the 'new hunk' sections.
- When quoting variables or names from the code, use backticks (`) instead of single quote (').
- Take into account that you are reviewing a PR code diff, and that the entire codebase is not available for you as context. Hence, avoid suggestions that might conflict with unseen parts of the codebase.
The output must be a YAML object equivalent to type $PRCodeSuggestions, according to the following Pydantic definitions:
class CodeSuggestion(BaseModel): relevant_file: str = Field(description="the relevant file full path") language: str = Field(description="the code language of the relevant file") suggestion_content: str = Field(description="an actionable suggestion for meaningfully improving the new code introduced in the PR") existing_code: str = Field(description="a short code snippet, demonstrating the relevant code lines from a 'new hunk' section. It must be without line numbers. Use abbreviations if needed") improved_code: str = Field(description="a new code snippet, that can be used to replace the relevant 'existing_code' lines in 'new hunk' code after applying the suggestion") one_sentence_summary: str = Field(description="a short summary of the suggestion action, in a single sentence. Focus on the 'what'. Be general, and avoid method or variable names.") relevant_lines_start: int = Field(description="The relevant line number, from a 'new hunk' section, where the suggestion starts (inclusive). Should be derived from the hunk line numbers, and correspond to the 'existing code' snippet above") relevant_lines_end: int = Field(description="The relevant line number, from a 'new hunk' section, where the suggestion ends (inclusive). Should be derived from the hunk line numbers, and correspond to the 'existing code' snippet above") label: str = Field(description="a single label for the suggestion, to help the user understand the suggestion type. For example: 'security', 'possible bug', 'possible issue', 'performance', 'enhancement', 'best practice', 'maintainability', etc. Other labels are also allowed")
class PRCodeSuggestions(BaseModel): code_suggestions: List[CodeSuggestion]
Example output:
code_suggestions:
- relevant_file: |
src/file1.py
language: |
python
suggestion_content: |
...
existing_code: |
...
improved_code: |
...
one_sentence_summary: |
...
relevant_lines_start: 12
relevant_lines_end: 13
label: |
...Each YAML output MUST be after a newline, indented, with block scalar indicator ('|'). 2024-07-03 22:11:19.675 | INFO | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:159 - User prompt: PR Info:
Title: 'xxx'
The PR Diff:
file: 'pr-agent.py'
@@ -0,0 +1,9 @@ new hunk 1 +# This program prints Hello, world! 2 + 3 +printfx('Hello, world!') 4 + 5 +for i=0; i<10; i++ { 6 + printfx("how to build for loop") 7 +} 8 + 9 +# There aare soome typooo
Response (should be a valid YAML, and nothing else):
2024-07-03 22:11:21.825 | DEBUG | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:176 -
AI response:
code_suggestions:
- relevant_file: |
src/pr-agent.py
language: |
2024-07-03 22:11:21.826 | DEBUG | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:180 - Full_response
2024-07-03 22:11:21.827 | INFO | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:184 -
AI response:
code_suggestions:
- relevant_file: |
src/pr-agent.py
language: |
2024-07-03 22:11:21.828 | DEBUG | pr_agent.tools.pr_code_suggestions:_prepare_pr_code_suggestions:248 - Skipping suggestion 1, because it does not contain 'one_sentence_summary':
'{'relevant_file': 'src/pr-agent.py\n', 'language': ''}
2024-07-03 22:11:21.830 | ERROR | pr_agent.tools.pr_code_suggestions:run:93 - No code suggestions found for PR.
2024-07-03 22:11:21.831 | DEBUG | pr_agent.tools.pr_code_suggestions:run:95 - PR output
(pr-agent) gyliu@guangyas-air pr-agent %
AI response: code_suggestions:
relevant_file: | pr-agent.py language: | python suggestion_content: | Replace
printfxwithprintto correct the function name for printing in Python. existing_code: | printfx('Hello, world!') improved_code: | print('Hello, world!') one_sentence_summary: | Correct the function name for printing output. relevant_lines_start: 3 relevant_lines_end: 3 label: | possible bugrelevant_file: | pr-agent.py language: | python suggestion_content: | Correct the syntax of the for loop to match Python's syntax. existing_code: | for i=0; i<10; i++ { printfx("how to build for loop") } improved_code: | for i in range(10): print("how to build for loop") one_sentence_summary: | Correct the syntax of the for loop to be Pythonic. relevant_lines_start: 5 relevant_lines_end: 7 label: | possible bug
relevant_file: | pr-agent.py language: | python suggestion_content: | Correct the spelling errors in the comment. existing_code: |
There aare soome typooo
improved_code: |
There are some typos
one_sentence_summary: | Correct spelling errors in the comment. relevant_lines_start: 9 relevant_lines_end: 9 label: | enhancement
suggestion_summary: | Correct the function name for printing output. relevant_file: "pr-agent.py" suggestion_score: 10 why: | The suggestion correctly identifies and fixes a major bug by replacing the incorrect
printfxfunction with the correctprintfunction in Python.suggestion_summary: | Correct the syntax of the for loop to be Pythonic. relevant_file: "pr-agent.py" suggestion_score: 10 why: | The suggestion accurately corrects the for loop syntax to match Python's syntax, which is crucial for the code to run properly.
suggestion_summary: | Correct spelling errors in the comment. relevant_file: "pr-agent.py" suggestion_score: 5 why: | The suggestion improves readability by fixing spelling errors in the comment, but it does not affect the functionality of the code.