multiformats / cid

Self-describing content-addressed identifiers for distributed systems
Other
426 stars 79 forks source link

Disambiguate base58 as base58btc to match multibase table. #10

Closed jeremyBanks closed 7 years ago

jeremyBanks commented 7 years ago

Resolves #9 by clarifying that CIDv0 uses the multibase encoding named base58btc.

This current version of ipld/cid specifies that for CIDv0:

the multibase is always base58 and implicit (not written).

However, the list in multiformats/multibase doesn't include any base exactly named base58...

base58flickr  Z       highest char
base58btc     z       highest char

...so I'm not sure which alphabet I should use.

ghost commented 7 years ago

Thanks :+1: Great catch!