search

multiformats / cs-multibase

Multibase implementation in C#
MIT License
16 stars 12 forks source link

Nonstandard encoding #4

Closed eth-r closed 6 years ago

eth-r commented 6 years ago

The encoding used by this library in bases 2, 8 and 10 is non-standard and incompatible with other implementations, conflicting with the intent of the multibase project

tabrath commented 6 years ago

Ok, I will look into this. When this was implemented there was no specification or other implementations for reference, so I hope there will be some test vectors all implementation can test against soon.

eth-r commented 6 years ago

I proposed a set of test vectors in https://github.com/multiformats/multibase/issues/24 to help standardize the libraries

tabrath commented 6 years ago

Nice, that's just what I need. I'll start working on this asap. Thank you.

tabrath commented 6 years ago

@eth-r Released a new version of the library, it's completely rewritten and passes all your test vectors now and fixes multiformats/multibase#34.