search

multiformats / go-multiaddr-net

DEPRECATED: Please use the "net" subpackage in https://github.com/multiformats/go-multiaddr.
MIT License
34 stars 26 forks source link

Fix travis builds not supporting ipv6 by default anymore #34

Closed hsanjuan closed 6 years ago

hsanjuan commented 6 years ago

License: MIT Signed-off-by: Hector Sanjuan code@hector.link

Stebalien commented 6 years ago

Actually, all you need to do is set sudo: true. The standard CI script now takes care of the rest.

hsanjuan commented 6 years ago

that makes no sense, but ok

hsanjuan commented 6 years ago

@Stebalien that doesn't work https://travis-ci.org/multiformats/go-multiaddr-net/builds/333480923?utm_source=github_status&utm_medium=notification

Stebalien commented 6 years ago

Ah! The issue is that this repo doesn't use our standard scripts. I'll fix that.

As for what sudo: true does..., it allows os to, as root, enable proper IPv6 support: https://github.com/ipfs/ci-helpers/blob/master/travis-ci/run-standard-tests.sh#L31. We don't bother with an explicit "enable ipv6" flag because we always want it enabled if we have root. Unfortunately, travis disables it by default...

Stebalien commented 6 years ago

See #35. Note: we moved to a standard, single CI script to avoid having to copy fixes like this all over the place.

hsanjuan commented 6 years ago

Sorry, when you said standard CI script I understood some travis stardard thing. I did not know that we had our own CI script as shown in the other PR.