multiformats / go-multibase

Implementation of multibase parser in go
MIT License
33 stars 17 forks source link

Add simple utility to convert from one base to another. #13

Closed kevina closed 7 years ago

kevina commented 7 years ago

Might be useful, not a high priority at all. Wrote for my own purposes.

Kubuxu commented 7 years ago

I have updated it, @hsanjuan do you want to CR it?

Kubuxu commented 7 years ago

Thanks for looking it over, I just updated it and didn't really CR it.

kevina commented 7 years ago

Hey, sorry I forgot about the P.R. Next time I don't respond to a comment can you please ping me again and give me a day or so, before taking it over. Thanks.

Please give me a chance to look over Kubuxu changes before accepting this.

hsanjuan commented 7 years ago

LGTM. @kevina sure, take a look and let us know if it works for you or you want to change something. Thanks!

Kubuxu commented 7 years ago

Heh, I can't request your review as you are the author. Sorry for taking it over and a short notice.

kevina commented 7 years ago

@Kubuxu yeah. I give it a LGTM once I have a chance to review your changes.

kevina commented 7 years ago

So why are they not CID's? is it because the string technically doesn't have to be a CID. Just some random string with a multibase prefix?

Kubuxu commented 7 years ago

Yes

kevina commented 7 years ago

LGTM. Than.