search

multiformats / go-multihash

Multihash implementation in Go
MIT License
239 stars 57 forks source link

Please choose between identity / id and stick to it across all projects #113

Closed Gozala closed 5 years ago

Gozala commented 5 years ago

I recently discovered that what go names id

https://github.com/multiformats/go-multihash/blob/0e239d8fa37b597bd150660e5b6845570aa5b833/multihash.go#L92

JS calls identity

https://github.com/multiformats/js-multihash/issues/70

Which is confusing, but then I also discovered that multicodec table also refers to 0x00 as identity.

Please pick either name but stick to one across projects otherwise it's very confusing.

Stebalien commented 5 years ago

Yeah, it should be "identity".