multiformats / go-multihash

Multihash implementation in Go
MIT License
239 stars 57 forks source link

Split core types into a core subpackage #131

Closed Stebalien closed 3 years ago

Stebalien commented 4 years ago

Currently, the core Multihash type and the Sum function are defined in the same package. This means anyone who wants to import the type also needs to import the sum function, pulling in all the hashing libraries at the same time.

Instead, we should:

That way, packages that depend on these types can directly import the core package, reducing binary size.

Replaces #78.

warpfork commented 3 years ago

I believe this is now closed by #136 :tada:

(If there's additional specific work this didn't cover yet, it probably could use a fresh issue to enumerate it.)