multiformats / go-multihash

Multihash implementation in Go
MIT License
239 stars 57 forks source link

continuation of conversion of multihash to string #84

Closed kevina closed 3 years ago

kevina commented 6 years ago

Continuation of #83 using parts of #82.

kevina commented 6 years ago

@Stebalien Do you want to get this is now with the Cid changes?

Stebalien commented 6 years ago

If you feel secure in your gx-fu. The package list is quite long:

go-libp2p-peer
go-multiaddr
go-multiaddr-net
mafmt
go-libp2p-peerstore
go-libp2p-net
go-conn-security
go-libp2p-secio
iptb
go-ipfs-util
go-libp2p-loggables
go-libp2p-transport
go-reuseport-transport
go-maddr-filter
go-libp2p-transport-upgrader
go-tcp-transport
go-testutil
go-libp2p-metrics
go-libp2p-interface-connmgr
go-libp2p-host
go-addr-util
go-conn-security-multistream
go-libp2p-swarm
go-libp2p-nat
go-libp2p-netutil
go-libp2p-blankhost
go-libp2p-circuit
go-multiaddr-dns
go-ws-transport
go-libp2p
go-cid
go-libp2p-record
go-libp2p-kbucket
go-libp2p-routing
go-libp2p-kad-dht
hang-fds
go-libp2p-floodsub
go-block-format
go-ipld-format
go-ipld-cbor
go-ipfs-cmds
go-ipld-git
go-libp2p-connmgr
go-ipfs-addr
go-ipfs-posinfo
go-ipfs-chunker
go-ipfs-ds-help
go-ipfs-routing
go-ipfs-blockstore
go-fs-lock
go-ipfs-exchange-interface
go-ipfs-blocksutil
go-ipfs-exchange-offline
go-libp2p-routing-helpers
go-libp2p-pubsub-router
go-ipns
go-ipfs

The package list for go-cid is only:

go-libp2p-routing
go-libp2p-kad-dht
go-block-format
go-ipld-format
go-ipld-cbor
go-ipld-git
go-ipfs-posinfo
go-ipfs-chunker
go-ipfs-ds-help
go-ipfs-routing
go-ipfs-blockstore
go-ipfs-exchange-interface
go-ipfs-blocksutil
go-ipfs-exchange-offline
go-libp2p-routing-helpers
go-libp2p-pubsub-router
go-ipfs

Regardless, let's be very careful not to get stuck half-way (i.e., no pushing to master until the end).

kevina commented 6 years ago

@Stebalien I can try (the full gx-update with multihash). It may be helpful if I do it at a time when you are around so you can walk me though and make sure everything looks good.

So that I am confident you are okay with all the changes please Approve this p.r., https://github.com/ipfs/go-cid/pull/71 and https://github.com/ipfs/go-cid/pull/73.

Stebalien commented 6 years ago

Only @kevina should merge this. CI fails because this breaks go-libp2p-peer.

@kevina modulo the one comment on go-cid, this all looks good to me. I'd:

  1. Start by not using gx. Instead, just fix all the appropriate packages (picking up where I left off), testing with go.
  2. Once that all works, we can use gx-workspace to make this happen (if it looks too gnarly, I can take a stab at this; this'll be interesting...).
lidel commented 3 years ago

Closing due to being stale since 2018 + merge conflicts.