search

multiformats / go-multistream

an implementation of the multistream protocol in go
MIT License
40 stars 27 forks source link

release v0.4.1 #101

Closed MarcoPolo closed 1 year ago

marten-seemann commented 1 year ago

Now that’s annoying. Would gorelease still insist on a new minor version if we exclude the Go version bump?

MarcoPolo commented 1 year ago

What's the benefit of keeping it a patch release in this case?

marten-seemann commented 1 year ago

If it’s a minor release, the go-libp2p release will have to be another minor as well, according to semver.

MarcoPolo commented 1 year ago

Can I simply merge it as a patch or is there something else I should do?

github-actions[bot] commented 1 year ago

Suggested version: v0.4.1

Comparing to: v0.4.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index ae42922..868c702 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,5 @@
 module github.com/multiformats/go-multistream

-go 1.18
+go 1.19

 require github.com/multiformats/go-varint v0.0.6

gorelease says:

# github.com/multiformats/go-multistream
## incompatible changes
ErrNotSupported: changed from ErrNotSupported[T StringLike] to ErrNotSupported[T StringLike]
Handler: changed from Handler[T StringLike] to Handler[T StringLike]
HandlerFunc: changed from HandlerFunc[T StringLike] to HandlerFunc[T StringLike]
MultistreamMuxer: changed from MultistreamMuxer[T StringLike] to MultistreamMuxer[T StringLike]
NewMultistreamMuxer: changed from func() *MultistreamMuxer[T] to func() *MultistreamMuxer[T]

# summary
Suggested version: v0.5.0

gocompat says:

Your branch is up to date with 'origin/master'.

Automatically created GitHub Release

A draft GitHub Release has been created. It is going to be published when this PR is merged. You can modify its' body to include any release notes you wish to include with the release.

MarcoPolo commented 1 year ago

Currently thinking this is a gorelease bug because this output looks identical:

# github.com/multiformats/go-multistream
## incompatible changes
ErrNotSupported: changed from ErrNotSupported[T StringLike] to ErrNotSupported[T StringLike]
Handler: changed from Handler[T StringLike] to Handler[T StringLike]
HandlerFunc: changed from HandlerFunc[T StringLike] to HandlerFunc[T StringLike]
MultistreamMuxer: changed from MultistreamMuxer[T StringLike] to MultistreamMuxer[T StringLike]
NewMultistreamMuxer: changed from func() *MultistreamMuxer[T] to func() *MultistreamMuxer[T]

# summary
Suggested version: v0.5.0

Also if you run gorelease from v0.4.0 branch, you'll still get the suggested version v0.5.0