search

multiformats / go-multistream

an implementation of the multistream protocol in go
MIT License
40 stars 27 forks source link

manual release created (v0.5.0) #109

Closed github-actions[bot] closed 7 months ago

github-actions[bot] commented 1 year ago

@marten-seemann just pushed a release tag: v0.5.0. Please manually verify validity (using `gorelease`), and update `version.json` to reflect the manually released version, if necessary. In the future, please use the automated process.

marten-seemann commented 1 year ago

@galargh I edited the release notes, and clicked "Publish" instead of "Save Draft". Apparently that creates a release on master (?). Is there any way to prevent that?

marten-seemann commented 1 year ago

We can live with the current situation, we tagged 8fabf3a244c16743222174f11b43cf4a47c6d5e8 instead of the release commit. No functional changes in this case though (this doesn't apply in the general case, the release commit could contain code changes).

galargh commented 12 months ago

One way to prevent that would be to create the draft release without the tag set. We could set it when the automation publishes the release. The downside is that you wouldn't be able to inspect the tag that's going to get released inside the draft but I think that's acceptable. WDYT?