Fix race condition for whandshake

multiformats / go-multistream

an implementation of the multistream protocol in go

MIT License

41 stars 27 forks source link

Fix race condition for whandshake #16

Closed JustinDrake closed 6 years ago

JustinDrake commented 7 years ago

See race condition reported at https://github.com/ipfs/go-ipfs/issues/4105

Reuse whlock for whandshake

coveralls commented 7 years ago

Coverage increased (+0.2%) to 79.657% when pulling adda1dd7de01ecec4782c4a1b6e45cb9cb0b7997 on JustinDrake:patch-1 into b8f1996688ab586031517919b49b1967fca8d5d9 on multiformats:master.

Kubuxu commented 7 years ago

I will dig into that concurrency here to make sure it is correct. I hope you won't mind if I come up with alternate solution.

JustinDrake commented 7 years ago

No problem @Kubuxu. Thanks for looking into it 👍

Stebalien commented 6 years ago

Fix in #21.