Open Stebalien opened 6 years ago
@diasdavid thoughts? (FYI, by "it never worked", I mean "it never worked in go"). It looks like js-libp2p does support this but I'd still like to go one way or another. Either support listing supported protocols or don't support listing supported protocols.
To make this clear, we have two conflicting features:
ls
to list all supported protocols.There are three ways of fixing this:
ls
protocol.ls
protocol to only list known protocols.I filed this PR because the dynamic protocol feature is currently broken in go (and has never worked).
So... It turns out that the ls
protocol is also broken in go.
ls
protocol first (that is, it just sends back the list of supported protocols without sending back <len>ls\n
first.ðŸ˜
reverts c9587f16af873eced8fd29ea66c9c777d5c35d09
Alternatively (I'd actually prefer this) we should consider removing the "ls" command. That's not the job of this protocol (should use, e.g., an identify service).