Implement simultaneous open extension

multiformats / go-multistream

an implementation of the multistream protocol in go

MIT License

40 stars 27 forks source link

Implement simultaneous open extension #42

Closed vyzo closed 3 years ago

vyzo commented 5 years ago

For https://github.com/libp2p/go-libp2p/issues/1039.

Implements this Spec: https://github.com/libp2p/specs/pull/196

TBD:

[X] tests!
[X] use parallel goroutines for writing in simultaneous read/write paths

vyzo commented 4 years ago

ping @Stebalien @raulk

vyzo commented 4 years ago

@raulk what scenarios do you want to test? We can certainly add more tests.

aarshkshah1992 commented 3 years ago

Ping @Stebalien @marten-seemann for review.

aarshkshah1992 commented 3 years ago

@Stebalien Have addressed all your comments. Please can you take a look ?

aarshkshah1992 commented 3 years ago

@marten-seemann @Stebalien

Have addressed all review comments so far. Please approve if happy and we can ship !

vyzo commented 3 years ago

For the record, I find the use of a uint strictly worse than the original spec from a protocol standpoint; but then again it doesn't matter much at the end of the day. We do need to update the spec for what was actually implemented however.