ls: make ls more consistent with other protocols

multiformats / go-multistream

an implementation of the multistream protocol in go

MIT License

41 stars 27 forks source link

ls: make ls more consistent with other protocols #43

Closed Stebalien closed 5 years ago

Stebalien commented 5 years ago

fixes #41

Note: To make the Ls helper actually useful, it now performs the handshake internally. Really, this library isn't built for interactive use while ls is so the interfaces are going to be kind of wonky.

Stebalien commented 5 years ago

@alanshaw let's wait for a spec change. Want to file a PR?

alanshaw commented 5 years ago

PR here https://github.com/multiformats/multistream-select/pull/19 which I believe matches the implementation here.