search

multiformats / go-multistream

an implementation of the multistream protocol in go
MIT License
41 stars 27 forks source link

fix: don't write from the read function #50

Closed Stebalien closed 4 years ago

Stebalien commented 4 years ago

This was causing a double-write.

fixes https://github.com/libp2p/go-libp2p-pnet/issues/31 probably fixes https://github.com/ipfs/go-ipfs/issues/6802 fixes https://github.com/ipfs/go-ipfs/issues/6197

Stebalien commented 4 years ago

cc @bonedaddy

Stebalien commented 4 years ago

After we merge this, we can revert https://github.com/libp2p/go-ws-transport/pull/65.