multiformats / go-multistream

an implementation of the multistream protocol in go
MIT License
41 stars 27 forks source link

Ignore error if can't write back multistream protocol id #89

Closed MarcoPolo closed 2 years ago

MarcoPolo commented 2 years ago

A continuation of https://github.com/multiformats/go-multistream/pull/87. It's the same thing, but we didn't account for the case the the stream is closed so early we don't get a chance to write our multistream select protocol id.

Worth noting that the old NegotiateLazy also ignored this error, so it should be a safe change (since this is the same as the old behavior).