fix(api): set default base when using toV1 from V0

multiformats / js-cid

CID implementation in JavaScript

MIT License

97 stars 39 forks source link

Closed ocknamo closed 3 years ago

ocknamo commented 3 years ago

This PR is fix toV1 API to set default base to base32 when convert from V0.

More details are here.

lidel commented 3 years ago

CID should not include any implicit conversions – those should be done explicitly in ht e code that consumes this library: new CID('QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR').toV1().toString('base32')
js-cid will be superseded by multiformats/cid (https://github.com/multiformats/js-multiformats) and cids will be deprecated