Closed Gozala closed 5 years ago
I don’t know enough about flow to know if this is correct or not so I’ll just trust that you did it correctly and merge it :)
whoops! my bad, I thought this was a different repo cause we were talking about this same thing there. I should not have merged this before others had reviewed it.
can we get some +1’s here and if people have objections i can back it out.
This was planned over a year ago https://github.com/ipfs/js-ipfs/issues/1260 but seems to have stalled until now. @vmx are you planning on working on it this quarter?
No real plan to work on it, but somehow I got dragged into this and as I'm still in favour of it (though this time less intrusive with using the inline comment style) I think I'll spend some time on it.
somehow I got dragged into this
@vmx I’m sorry
Add flow type definitions which would improve workflow for dependent libraries that happen to use flow type-checker.
This just
index.js.flow
is what flow would resolve to when imported module resolves toindex.js
and there for dependencies of this library will be able to infer type info.