Skypack build failing with multiformats@9.4.5

vasco-santos commented 3 years ago

multiformats module was previously working fine in skypack, but with the latest release (9.4.5) its build is now failing, as you can see in https://codepen.io/vascosantos/pen/qBjByRo?editors=0011

The build error can be seen in https://cdn.skypack.dev/error/build:multiformats@v9.4.5-XS9DnCaqHDNVqc6Q8qvD . Doing a simple https://cdn.skypack.dev/multiformats@9.4.4/cid works fine, but if we change the version to the next one it will be forwarded for the build error: https://cdn.skypack.dev/multiformats@9.4.5/cid

From 9.4.5 only setup node action was changed. Also, it seems that ipjs did not have any release between 9.4.4 and 9.4.5. With this in mind, I am clueless at this point of what is the problem here.

Any ideas @rvagg ?

rvagg commented 3 years ago

looking

rvagg commented 3 years ago

diff -Naur mf1/node_modules/multiformats/package.json mf2/node_modules/multiformats/package.json
--- mf1/node_modules/multiformats/package.json  1985-10-26 18:15:00.000000000 +1000
+++ mf2/node_modules/multiformats/package.json  1985-10-26 18:15:00.000000000 +1000
@@ -1,6 +1,6 @@
 {
   "name": "multiformats",
-  "version": "9.4.4",
+  "version": "9.4.5",
   "description": "Interface for multihash, multicodec, multibase and CID",
   "main": "./cjs/src/index.js",
   "types": "./types/index.d.ts",
diff -Naur mf1/node_modules/.package-lock.json mf2/node_modules/.package-lock.json
--- mf1/node_modules/.package-lock.json 2021-08-24 22:06:33.902975825 +1000
+++ mf2/node_modules/.package-lock.json 2021-08-24 22:06:41.495013141 +1000
@@ -3,9 +3,9 @@
   "requires": true,
   "packages": {
     "node_modules/multiformats": {
-      "version": "9.4.4",
-      "resolved": "https://registry.npmjs.org/multiformats/-/multiformats-9.4.4.tgz",
-      "integrity": "sha512-lGAP3Cuc4nHRq5q9EQZFGegXBlElmlfcz7d2xsDO/u4TG7M2kkdsGOaZPe9FIbfWugWPx643VTXgZctqqJfTzg=="
+      "version": "9.4.5",
+      "resolved": "https://registry.npmjs.org/multiformats/-/multiformats-9.4.5.tgz",
+      "integrity": "sha512-zQxukxsHM34EJi3yT3MkUlycY9wEouyrAz0PSN+CyCj6cYchJZ4LrTH74YtlsxVyAK6waz/gnVLmJwi3P0knKg=="
     }
   }
 }
diff -Naur mf1/package.json mf2/package.json
--- mf1/package.json    2021-08-24 22:06:33.902975825 +1000
+++ mf2/package.json    2021-08-24 22:06:41.495013141 +1000
@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "multiformats": "^9.4.4"
+    "multiformats": "^9.4.5"
   }
 }

nothing's changed between those two other than the expected, maybe we need to force a release to bump skypack .. will push something trivial and see.

rvagg commented 3 years ago

Version bump didn't work, opened an issue @ https://github.com/skypackjs/skypack-cdn/issues/209

If it's urgent, maybe get @mikeal to pull rank with Fred to get it look at. Logs would be interesting if they're having genuine problems.

vasco-santos commented 3 years ago

Thanks for looking into it @rvagg not urgent, given we could never get ipfs-car and web3.storage working with skypack yet.

Gozala commented 3 years ago

It looks like that current version works fine specifically import('https://cdn.skypack.dev/multiformats@9.4.10'), I suspect problem may have been one of the dependencies been resolved to a newer package was breaking the build.

multiformats / js-multiformats

Skypack build failing with multiformats@9.4.5 #115