search

multiformats / js-multihashing

Use all the functions in multihash.
MIT License
11 stars 18 forks source link

.verify has a confusing api #34

Open mkg20001 opened 5 years ago

mkg20001 commented 5 years ago

It apparently expects a multihash and a buffer to be compared. I find this a bit confusing. Instead shouldn't it simply be a comparison function?

daviddias commented 5 years ago

@mkg20001 it should match js-multihashing-async, which now is being redesigned as part of the https://github.com/ipfs/js-ipfs/issues/1670