search

multiformats / js-multihashing

Use all the functions in multihash.
MIT License
11 stars 18 forks source link

add .verify() for one-stop verification of a buffer against a hash #5

Closed candeira closed 6 years ago

candeira commented 8 years ago

Rationale: .verify() will likely be the most frequent operation, so it should be a shared utility function, not something endlessly reimplemented.

There are tests (they pass) and the library is lint clean. However, I didn't run a zuul test because I didn't have credentials.

daviddias commented 8 years ago

@candeira try npm run test:browser:q for testing locally in a browser (change version of Chrome to the latest (nowadays is 47) ) https://github.com/jbenet/js-multihashing/blob/master/package.json#L10)

candeira commented 8 years ago

@diasdavid I tried, but npm run test:browser:q doesn't test locally, but just injects some values in environment variables, then calls run test:browser, which calls on zuul, which again requires saucelab credentials.

daviddias commented 8 years ago

@candeira you are right, forgot about that step :)

harlantwood commented 8 years ago

+1 for .verify(...)

daviddias commented 7 years ago

Hi @candeira, seems that this module has changed a ton since your PR, could you rebase it on top of current master?

Thank you!

daviddias commented 7 years ago

ping @candeira

daviddias commented 6 years ago

@candeira still interested in pushing this PR?

hacdias commented 6 years ago

@diasdavid is the idea of implementing the .verify() function still alive?