Potential import collision: import path should be "github.com/rdumont/assistdog", not "github.com/hellomd/assistdog"

[KateGo520]

Background

I find that github.com/rdumont/assistdog and github.com/hellomd/assistdog coexist in this repo： https://github.com/multiformats/multiaddr/blob/master/test/go.mod （Line 10 & 5）

github.com/hellomd/assistdog v0.0.0-20171107191847-c91d7a54538c 
github.com/rdumont/assistdog v0.0.0-20171107191847-c91d7a54538c // indirect 

That’s because the assistdog has already renamed it’s import path from "github.com/hellomd/assistdog" to "github.com/rdumont/assistdog". When you used the old path "github.com/hellomd/assistdog" to import assistdog, go will reintroduces assistdog through the import statements "import github.com/rdumont/assistdog/…" in the go source file of assistdog.

https://github.com/rdumont/assistdog/blob/c91d7a54538c6d66d976d4e71ad31b8661eddea3/assist.go#L11

package assistdog
import (
    "github.com/DATA-DOG/godog/gherkin"
    "github.com/rdumont/assistdog/defaults"
    …
) 

The "github.com/rdumont/assistdog" and "github.com/hellomd/assistdog" are the same repos. This will work in isolation, bring about potential risks and problems.

Solution

Replace all the old import paths, change "github.com/hellomd/assistdog" to "github.com/rdumont/assistdog ". Where did you import it: https://github.com/multiformats/multiaddr/search?q=hellomd%2Fassistdog&unscoped_q=hellomd%2Fassistdog

[KateGo520]

@olizilla @aratz-lasa Could you help me review this issue? Thx :p