MarcoPolo
commented
2 years ago As far as I can tell, this is missing an update to https://github.com/multiformats/multicodec/blob/master/table.csv, correct? @MarcoPolo can you do the update?
Ah thanks. I didn't realize we had these two sources of truth. That doesn't seem ideal. I wonder if there's a strategy we can use to keep them in sync. Maybe a CI check in this repo?
On a general note, I would suggest keeping pull requests open for longer than 12h before merging. That would allow everyone in the community to comment, no matter which timezone they are in.
Sounds good to me. What should the timeout be? 24 hours?
This change I considered pretty uncontroversial because there's been an sni example in the readme for 5 years. So it's more surprising that this didn't already exist. But in general I agree.
I'll make a PR template to make these things explicit.
This registers the SNI component which can be used by transports to set the sni field in their client hello. See RFC 6066 section 3 for more details.
We need this so that secure websocket clients can know what SNI to send when connecting to an ip address.