search

multiformats / multicodec

Compact self-describing codecs. Save space by using predefined multicodec tables.
MIT License
340 stars 204 forks source link

Make TLS permanent #215

Closed carpawell closed 1 year ago

carpawell commented 3 years ago

There are https://github.com/multiformats/go-multiaddr/pull/153 and https://github.com/multiformats/multiaddr/pull/109 PR's that add TLS.

Also, TLS is used in examples in README in the main repo.

Therefore, it seems logical to make it permanent.

rvagg commented 3 years ago

permanent - this codec has been widely adopted and may not reassigned.

I would say that while TLS is widely adopted itself, that use of the codec code here may not be - and you've linked to PRs, not merged and released code.

The fact that it's draft shouldn't be interpreted as it being at imminent risk of being removed, that's not the case at all. We've removed very few entries from the table and mostly that's happened immediately after merge when we realised it was a mistake. So it's more of a journey toward permanent, with the preference to not lock in entries where they aren't in heavy use - like dag-pb, for instance.

So I'm -1 on this for now, but it's certainly a good candidate for permanent if we see this code being widely used.

carpawell commented 3 years ago

So it is ok, if draft != can be deleted. My only misunderstanding was about using it as an example in the main repo and also that TLS is certainly a wildly used protocol, but somehow it is "draft".

BTW, both PRs that I linked were merged.

Stebalien commented 3 years ago

My only misunderstanding was about using it as an example in the main repo and also that TLS is certainly a wildly used protocol, but somehow it is "draft".

TLS is widely used. The TLS multicodec is not.