search

multiformats / multicodec

Compact self-describing codecs. Save space by using predefined multicodec tables.
MIT License
336 stars 201 forks source link

Add 'host-header' to table.csv #296

Closed thibmeu closed 1 year ago

thibmeu commented 1 year ago

Host header as defined by HTTP RFC 2616 § 14.23.

Relates to multiformats/multiaddr#144 and libp2p/go-libp2p#1829

cc @MarcoPolo

rvagg commented 1 year ago

So this is basically like sni in a multiaddr? Seams reasonable to me. The name is a little verbose but I suppose host isn't really a good option either! Will leave it up to the multiaddr/libp2p folks to approve and merge. @mxinden @marten-seemann.

rvagg commented 1 year ago

@thibmeu it's failing validation (you can run validate.py for yourself to check), needs a comma after host-header.

MarcoPolo commented 1 year ago

So this is basically like sni in a multiaddr? Seams reasonable to me. The name is a little verbose but I suppose host isn't really a good option either!

Yup. sni is just for TLS. This will set the host header for http.

thibmeu commented 1 year ago

@thibmeu it's failing validation (you can run validate.py for yourself to check), needs a comma after host-header.

fixed

BigLep commented 1 year ago

@MarcoPolo or @marten-seemann : can you please review/merge? (this came up in IPLD triage)

MarcoPolo commented 1 year ago

Do folks need this? We didn't end up needing this because SNI and Host is so tightly linked we chose to use only SNI for now. But this should be fine to merge if we need it

MarcoPolo commented 1 year ago

Closing this for now. Feel free to reopen if needed.