multiformats / multicodec

Compact self-describing codecs. Save space by using predefined multicodec tables.
MIT License
338 stars 202 forks source link

Add Varsig Multiformat #322

Closed expede closed 1 year ago

expede commented 1 year ago

Hey all 👋 We ended up wanting a LOT more flexibilty in Varsig than a codec tag, and broke it out into its own spec here: https://github.com/ChainAgnostic/varsig

This is essentially multisig, except that sequence of letters has a widely-used namespace conflict in multisig wallets. To avoid confusion, it's "varsig", but almost certainly belongs in the block with the other multiformats.

If useful, we can remove the previously-added draft signature types from this table, but I know historically there's been resistence to that. I'm happy either way 👍

expede commented 1 year ago

Awesome thanks @vmx :) @rvagg any objections?

rvagg commented 1 year ago

sgtm; although "nonstandard-sig" - is this just a legacy thing now and the rename is a way of deprecating it? If so, should we just add a note in the description column that it's going to be removed, or at least that it's not intended to be used for anything going forward?

expede commented 1 year ago

should we just add a note in the description column that it's going to be removed

Yeah totally — happy to deprecate those. Will do shortly