search

multiformats / multicodec

Compact self-describing codecs. Save space by using predefined multicodec tables.
MIT License
338 stars 202 forks source link

Add code for SCION multiaddrs #325

Closed leonrinkel closed 1 year ago

leonrinkel commented 1 year ago

We'd like to upstream libp2p support for the SCION Internet architecture. As a first step, this PR reserves a code for SCION multiaddrs like /scion/19-ffaa:1:1079....

rvagg commented 1 year ago

I'll wait for @leonrinkel's response to the above question, but wrt multiaddr and private range, we've recently had an issue with IPNI using a private range for httpath, in the wild, for some time now (although it seems like we might be heading in a different direction with this https://github.com/multiformats/multicodec/pull/324). Since multiaddrs get encoded in binary form, it does matter that the number is encoded in the table. So I think it's fine to go ahead with this as long as it seems reasonable that this isn't vapourware and we'll be stuck with an entry that never gets used at all.

leonrinkel commented 1 year ago

We do have an implementation that we're experimenting with and I'm trying to upstream it step by step. I just thought it would be the right order to do this first. I'll open a multiaddr PR asap, it's only minor version bumps in the SCION net library that I'm still waiting for. But I see your point, if you want to wait till then and cross-reference, that is also fine for me.