Open jbenet opened 8 years ago
Ok I will take a look at this soon.
We need:
@chriscool possible to take a look at this sooner? @Kubuxu wants to be able to test his c-multihash impl with it.
In js-land, we also need:
@RichardLitt possible for you to handle this one? or @dignifiedquire @diasdavid
I can help making the js cli compliant but I don't have time writing the tests.
nvm just saw the base setup will take a look at integrating Monday/Tuesday
PR #39 starts to implement some tests.
@jbenet: to make it easy to swap other binaries, do you want the test suite to check if for example the MULTIHASH env variable is defined and, in this case test $MULTIHASH instead of 'multihash'?
Also something we have discussed is separating multihash from multihashing. Meaning we should have two sets of tests, one for encoding and decoding and second for hashing.
@chriscool: yeah, maybe MULTIHASH_BIN ?
@Kubuxu: maybe. Let's start with just different test files in the sharness tests and break it out only once needed. On Sat, Aug 6, 2016 at 16:09 Jakub Sztandera notifications@github.com wrote:
Also something we have discussed is separating multihash from multihashing. Meaning we should have two sets of tests, one for encoding and decoding and second for hashing.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/multiformats/multihash/issues/32#issuecomment-238046401, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIcoW0hGl_xEOT4T0ZiUbcKzt9cUwEAks5qdOoBgaJpZM4I6eEy .
@dignifiedquire What is the status of the test suite?
@RichardLitt same as before, I completely forgot about this :/
@dignifiedquire Will you be able to get to it? Alternatively, I can take a look.
@RichardLitt please do so, but keep im mind js-multihasing-async is the main used module now
we should have a standard test suite in this repo, to be used across implementations.
Perhaps:
@chriscool maybe this is something you could help with? o/
Proposed options of the bin: