search

multiformats / py-multiaddr

multiaddr implementation in Python
https://multiformats.io/
Other
33 stars 23 forks source link

Add more tests #16

Closed JesseWeinstein closed 8 years ago

JesseWeinstein commented 8 years ago

This is as close to 100% as I can get it (see #17 and #18 for the remainder). So, it's ready to merge!

I plan to add more to this, but I may get delayed, so (assuming this passes), feel free to merge it now.

codecov-io commented 8 years ago

Current coverage is 99.15%

Merging #16 into master will increase coverage by 4.21%

@@             master        #16   diff @@
==========================================
  Files             5          5          
  Lines           356        356          
  Methods           0          0          
  Messages          0          0          
  Branches         62         62          
==========================================
+ Hits            338        353    +15   
+ Misses           10          1     -9   
+ Partials          8          2     -6

Powered by Codecov. Last updated by 2a7a2e1...8110e33

sbuss commented 8 years ago

Thanks, @JesseWeinstein! Sorry this review took so long, I've been busy but I'm trying to get back to regular maintenance now.

JesseWeinstein commented 8 years ago

No worries about the delay. Life happens.