search

multiformats / py-multibase

Multibase implementation in Python
MIT License
22 stars 9 forks source link

Add support for 'base36' and 'base36upper' multibase encodings #14

Closed cardoso-neto closed 3 years ago

cardoso-neto commented 3 years ago

I was perusing multiformats/py-multibase's fork network and found this great work by pinnaculum.

What do you guys think?

pinnaculum commented 3 years ago

Hello,

Sorry i was just about to create a pull request from the base36 branch when i saw that @cardoso-neto had already done it :+1:

Added base36 because now go-ipfs (since version 0.7) uses base36 for IPNS keys by default and since galacteek uses go-ipfs v0.7 now i needed base36 support so that py-cid can load base36-encoded CIDv1 (it works).

Just removed the version bumps (i needed to change at least the version in setup.py because i use my fork as an external dependency).

Thanks for py-multibase and py-cid :+1: Tell me if something else is needed.

dhruvbaldawa commented 3 years ago

Thank you for your contribution! I have approved the PR, you can merge the PR and I can then release it, or if you wish I can do that as well :)

pinnaculum commented 3 years ago

Thank you for your contribution! I have approved the PR, you can merge the PR and I can then release it, or if you wish I can do that as well :)

You're welcome. Since @cardoso-neto created the PR i can't merge it, you should probably do it. Will be nice to have 1.0.2 with base36 on pypi.