search

multiformats / rust-cid

CID in rust
86 stars 49 forks source link

Incompatible multihash #148

Closed retrohacker closed 9 months ago

retrohacker commented 10 months ago

I'm rather new to Rust so unsure how to solve this on my end. Might be trivial, if so sorry for the noise.

Looks like the latest release of cid is 0.10.1, which uses multihash 0.18.1.

But libp2p-core, libp2p-identity, libp2p-noise, and multiaddr are on 0.19.1, as are my crates.

When I try to create a cid_v1 from a 0.19.1 multihash, it doesn't compile complaining that Multihash<64> and MultihashGeneric<64> have similar names but are distinct types.

It looks like the main branch has the 0.19.1 version of multiaddr. Is it possible to cut a new release of the CID crate?

retrohacker commented 10 months ago

Was able to get it working with cargo add --git https://github.com/multiformats/rust-cid for now.

vmx commented 10 months ago

A new release is on my TODO list :)

retrohacker commented 9 months ago

Thanks for the release!