search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

fix: avoid allocations in `Display` and `Debug` of `Multiaddr` #106

Closed hrxi closed 9 months ago

hrxi commented 9 months ago

No, just happened to read these implementations by chance, and saw that they allocate. I remembered that we include them in a lot of log messages so I thought it might be worth sending a PR.

Should I also write a changelog entry if I don't need a patch release?

mxinden commented 9 months ago

Should I also write a changelog entry if I don't need a patch release?

Fine without. Will be released whenever we cut a new release.

Thank you!