multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

Build fails on rust stable due to CID crate #38

Closed JamesHageman closed 3 years ago

JamesHageman commented 4 years ago
$ cargo --version
cargo 1.42.0 (86334295e 2020-01-31)
$ git rev-parse --short HEAD
9682623
$ cargo build
   Compiling multiaddr v0.3.1 (/Users/jameshageman/Documents/Github/school/fydp/rust-multiaddr)
warning: trait objects without an explicit `dyn` are deprecated
  --> src/errors.rs:13:22
   |
13 |     ParsingError(Box<error::Error + Send + Sync>),
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error + Send + Sync`
   |
   = note: `#[warn(bare_trait_objects)]` on by default

warning: trait objects without an explicit `dyn` are deprecated
  --> src/errors.rs:34:32
   |
34 |     fn cause(&self) -> Option<&error::Error> {
   |                                ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error`

warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
  --> src/errors.rs:18:21
   |
18 |         f.write_str(error::Error::description(self))
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

error[E0277]: the trait bound `cid::Error: std::error::Error` is not satisfied
  --> src/errors.rs:50:33
   |
50 |         Error::ParsingError(err.into())
   |                                 ^^^^ the trait `std::error::Error` is not implemented for `cid::Error`
   |
   = note: required because of the requirements on the impl of `std::convert::From<cid::Error>` for `std::boxed::Box<dyn std::error::Error + std::marker::Send + std::marker::Sync>`
   = note: required because of the requirements on the impl of `std::convert::Into<std::boxed::Box<dyn std::error::Error + std::marker::Send + std::marker::Sync>>` for `cid::Error`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `multiaddr`.

To learn more, run the command again with --verbose.

Just thought I'd flag the build failure - it looks like #37 is addressing it.

mxinden commented 3 years ago

With https://github.com/multiformats/rust-multiaddr/pull/40 multiaddr no longer uses cid, thus I am closing here.