search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

*: Bump version to v0.15.0 and add changelog entries #58

Closed mxinden closed 2 years ago

mxinden commented 2 years ago

Follow up to #53 and #56.

mxinden commented 2 years ago

lgtm, but it is not actually a breaking change, is it?

In case a user exhaustively matches on Protocol, compilation will fail due to the new variant Protocol::Noise.

dignifiedquire commented 2 years ago

then maybe add non_exhaustive to the enzm for easier additions in the future?

mxinden commented 2 years ago

then maybe add non_exhaustive to the enzm for easier additions in the future?

I would argue that as a downstream user I would appreciate the breaking change in Protocol, i.e. I would appreciate to be notified of the change (additional variant) by the compiler. There are some downstream users who would want to make use of the new protocol, e.g. a Prometheus exporter which is tracking the observed protocols as a metric.