search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

add `/webrtc` and `/certhash` #59

Closed melekes closed 2 years ago

melekes commented 2 years ago

https://github.com/multiformats/multiaddr/pull/131

melekes commented 2 years ago

Are there any plans to merge this?

melekes commented 2 years ago

Sorry for the delay here @melekes.

Given the ongoing discussion in multiformats/multiaddr#130 I have postponed merging here. Sorry for not communicating that clearly.

Would you mind using your fork in libp2p/rust-libp2p#2622 a bit longer until the discussion settles?

ah, thanks for linking that discussion.

mxinden commented 2 years ago

With https://github.com/libp2p/specs/pull/412/commits/7009f943d5b9ee67cb7a19bbf8ca60549c1ad683 I will merge here, thus allowing https://github.com/libp2p/rust-libp2p/pull/2622 to point to the multiaddr master branch.

tomaka commented 2 years ago

With https://github.com/libp2p/specs/commit/7009f943d5b9ee67cb7a19bbf8ca60549c1ad683 I will merge here, thus allowing https://github.com/libp2p/rust-libp2p/pull/2622 to point to the multiaddr master branch.

This is why I don't bother commenting in libp2p/specs. After many attempts, the outcome is always the same: there's a conversation, then what I argue about gets ignored and the Protocol Labs version is picked as-is.