search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

CHANGELOG: Prepare v0.16.0 #62

Closed mxinden closed 1 year ago

mxinden commented 1 year ago

Unlocks https://github.com/libp2p/rust-libp2p/pull/2982.

Any objections by anyone? Anything else you would like to see included?

mxinden commented 1 year ago

//CC @John-LittleBearLabs

mxinden commented 1 year ago

Friendly ping @dignifiedquire as the Captain of the project.

On a related note, I am happy to officially co-maintain this project @dignifiedquire if you would like help.

elenaf9 commented 1 year ago

If this is not super urgent I'd like to include the changes proposed in https://github.com/multiformats/multiaddr/pull/147, for which I will do a PR on rust-multiaddr in the next days. Since libp2p/rust-libp2p#2289 is blocked on it I'd like to have it included in this release.

mxinden commented 1 year ago

If this is not super urgent I'd like to include the changes proposed in multiformats/multiaddr#147, for which I will do a PR on rust-multiaddr in the next days. Since libp2p/rust-libp2p#2289 is blocked on it I'd like to have it included in this release.

I suggest we don't block on your upcoming pull request to add /quic-v1 here. In case it makes it in time, great. In case it doesn't, I am happy to cut another release right after your upcoming pull request has been merged.

marten-seemann commented 1 year ago

If this is not super urgent I'd like to include the changes proposed in multiformats/multiaddr#147, for which I will do a PR on rust-multiaddr in the next days. Since libp2p/rust-libp2p#2289 is blocked on it I'd like to have it included in this release.

I suggest we don't block on your upcoming pull request to add /quic-v1 here. In case it makes it in time, great. In case it doesn't, I am happy to cut another release right after your upcoming pull request has been merged.

It would be a very sad state of affairs if the existing QUIC code point was used for nodes that only speak QUIC v1. Currently, we have the property that every node that advertises the existing code point speaks QUIC draft-29 (and potentially QUIC v1 in addition).

marten-seemann commented 1 year ago

Not sure if I was commenting on the right issue, or if my comment even makes sense in this repo ;)

I just meant to caution against rolling out rust-libp2p with QUIC support using the existing code point, given that we seem to be converging on minting a new code point for QUIC v1.

mxinden commented 1 year ago

Not sure if I was commenting on the right issue, or if my comment even makes sense in this repo ;)

This release only releases https://github.com/multiformats/rust-multiaddr/pull/60.

Whether to block https://github.com/libp2p/rust-libp2p/pull/2289 on https://github.com/multiformats/multiaddr/pull/147 is orthogonal to this release.

Your comment is important @marten-seemann. I suggest to move it to https://github.com/libp2p/rust-libp2p/pull/2289 or https://github.com/multiformats/multiaddr/pull/147

mxinden commented 1 year ago

Tagged and published.